Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RN][iOS] Improve Swift support for 3rd party libs #42075

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Dec 27, 2023

Summary:

We are suggesting and migrating 3rd party libs to use install_modules_dependencies in their podspecs.
However, when some of those libs uses Swift, they become incompatible with some of the pods we expose because we forgot to define modules in those libraries.

With these changes, they would be able to be installed correctly in a 0.72 react Native app.

Changelog:

[Internal] - Improve Swift support by defining modules in React-Fabric, React-graphics, React-utils and React-debug.

Test Plan:

Tested locally by running:

npx react-native@0.72.7 init NewApp --version 0.72.7 --skip-install
cd NewApp
yarn add lottie-react-native
cd ios
bundle install
RCT_NEW_ARCH_ENABLED=1 bundle exec pod install
open NewApp.xcworkspace

+ B

Observe the app failing to build.

Apply these changes:

RCT_NEW_ARCH_ENABLED=1 bundle exec pod install
open NewApp.xcworkspace

+ B

Observer the app build successfully

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Dec 27, 2023
@cipolleschi cipolleschi changed the base branch from main to 0.72-stable December 27, 2023 09:01
@cipolleschi cipolleschi marked this pull request as ready for review December 27, 2023 09:09
@kirillzyusko
Copy link

@cipolleschi I see 0.72.9 was releases recently, but this change wasn't included in release... Any information whether it'll be included in 0.72.10 or not? 👀

@cipolleschi
Copy link
Contributor Author

yeah, it will likely be included. We had to rush 0.72.9 because the iOS build pipeline was failing for the whole ecosyste due to boost not being downloadable from JFrog anymore.
So the release crew just fixed that issue and released .9 immediately to unblock everyone.

More info here: #42180

.10 will hopefully be a normal patch, with all the picks.

@kirillzyusko
Copy link

Got it @cipolleschi

Thank you for your detailed explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants